[9.x] Add hasUser
method to Guard contract
#39167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR by @TBlindaruk has been previously rejected at v5.8.
hasUser
method to Guard contract; #25629However, we are now at a new stage with many changes, such as introducing Contract on Query Builder implementation. I decided that it would be ready to resubmit this PR now. It is useful in some situations that knowing whether
user()
causes side effects in advance.Note that we don't have to add
setProvider()
andgetProvider()
because they are mainly for internal use.Breaking Changes
Guard
withoutGuardHelpers
should explicitly implementhasUser()
from now on.Guard
implementation which uses property caching should return! is_null($this->user)
Guard
without any caches should always returnfalse