Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Adds policy option to make:model #38725

Merged
merged 3 commits into from
Sep 10, 2021
Merged

[8.x] Adds policy option to make:model #38725

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22987f2
Adds policy option to make:model
tfevens Sep 8, 2021
22defeb
Style guide fixes
tfevens Sep 8, 2021
46d7093
Include --model to make:policy
tfevens Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/Illuminate/Foundation/Console/ModelMakeCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public function handle()
$this->input->setOption('seed', true);
$this->input->setOption('migration', true);
$this->input->setOption('controller', true);
$this->input->setOption('policy', true);
$this->input->setOption('resource', true);
}

Expand All @@ -60,6 +61,10 @@ public function handle()
$this->createSeeder();
}

if ($this->option('policy')) {
$this->createPolicy();
}

if ($this->option('controller') || $this->option('resource') || $this->option('api')) {
$this->createController();
}
Expand Down Expand Up @@ -113,6 +118,21 @@ protected function createSeeder()
]);
}

/**
* Create a policy file for the model.
*
* @return void
*/
protected function createPolicy()
{
$policy = Str::studly(class_basename($this->argument('name')));

$this->call('make:policy', [
'name' => "{$policy}Policy",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you want to pass --model here as well, that way the policy is generated for the model

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had debated that myself. Left it off as I felt that a quick scaffold would be better than nothing. But, if the community thinks that this is an option that would be better added in, it's something I can include quick and easy!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to ever include this it would definitely need to pass --model to make:policy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

'--model' => $this->qualifyClass($this->getNameInput()),
]);
}

/**
* Create a controller for the model.
*
Expand Down Expand Up @@ -175,11 +195,12 @@ protected function getDefaultNamespace($rootNamespace)
protected function getOptions()
{
return [
['all', 'a', InputOption::VALUE_NONE, 'Generate a migration, seeder, factory, and resource controller for the model'],
['all', 'a', InputOption::VALUE_NONE, 'Generate a migration, seeder, factory, policy, and resource controller for the model'],
['controller', 'c', InputOption::VALUE_NONE, 'Create a new controller for the model'],
['factory', 'f', InputOption::VALUE_NONE, 'Create a new factory for the model'],
['force', null, InputOption::VALUE_NONE, 'Create the class even if the model already exists'],
['migration', 'm', InputOption::VALUE_NONE, 'Create a new migration file for the model'],
['policy', null, InputOption::VALUE_NONE, 'Create a new policy file for the model'],
['seed', 's', InputOption::VALUE_NONE, 'Create a new seeder file for the model'],
['pivot', 'p', InputOption::VALUE_NONE, 'Indicates if the generated model should be a custom intermediate table model'],
['resource', 'r', InputOption::VALUE_NONE, 'Indicates if the generated controller should be a resource controller'],
Expand Down