[8.x] Add bad request test response assertion #38635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by PR laravel#38553. A readability enhancement in the same manner. Just like `assertOk`, `assertUnauthorized` and company this adds an `assertBadRequest` to ensure that a [400 Bad Request](https://datatracker.ietf.org/doc/html/rfc7231#section-6.5.1) was sent in the response. The intention is to increase readability and add broader support to the existing suite of response code assertions which are much easier to understand. This introduces no breaking changes since it does not modify any existing methods. Also introduced a test case for the assert error path and the path where there is no assertion error.
timmartin19
commented
Sep 1, 2021
Comment on lines
+495
to
+504
| $this->expectException(AssertionFailedError::class); | ||
|
|
||
| $this->expectExceptionMessage('Expected response status code'); | ||
|
|
||
| $baseResponse = tap(new Response, function ($response) use ($statusCode) { | ||
| $response->setStatusCode($statusCode); | ||
| }); | ||
|
|
||
| $response = TestResponse::fromBaseResponse($baseResponse); | ||
| $response->assertBadRequest(); |
There was a problem hiding this comment.
I noticed that this set of assertions was repeated a lot in this test class. It was outside the scope of this PR, but would people be interested in maybe converting some of these to using a dataProvider? Not 100% sure how it would look yet but it may help DRY this up.
There was a problem hiding this comment.
Obviously, that would be a separate PR
|
I honestly am getting a bit fatigued of these methods 😬 ... I almost always find just using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by PR #38553. A readability enhancement in the same manner.
Just like
assertOk,assertUnauthorizedand company this adds anassertBadRequestto ensure that a 400 Bad Request was sentin the response.
The intention is to increase readability and add broader support to the
existing suite of response code assertions which are much easier to
understand.
This introduces no breaking changes since it does not modify any
existing methods.
Also introduced a test case for the assert error path and the path where
there is no assertion error.