Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Rename boolean method in storage:link command #37508

Merged
merged 1 commit into from
May 28, 2021

Conversation

dinhquochan
Copy link
Contributor

Boolean methods often are prefixed with is.

@driesvints driesvints closed this May 28, 2021
@driesvints driesvints reopened this May 28, 2021
@driesvints
Copy link
Member

Sorry, realized that this is about a recent PR so it's unlikely that anyone is overwriting this method. Thanks for the PR.

@taylorotwell taylorotwell merged commit a1ecf52 into laravel:8.x May 28, 2021
@dinhquochan dinhquochan deleted the 8.x-rename-method branch June 4, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants