[8.x] Ensure the compiled view directory exists #36772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamCampbell tests are failing |
|
Let me take a look. Probably due to mocking. |
driesvints
approved these changes
Mar 26, 2021
GrahamCampbell
force-pushed
the
ensure-compiled-dir-exists
branch
from
faca025 to
545875f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like the file cache store.
NB The use case for this was setting
VIEW_COMPILED_PATH: /tmp/storage/framework/views, and having it "just work".NB2 This will not affect performance, since PHP caches checks for file/directory existence, so we don't need to worry about this being slow when compiling lots of views.