[9.x] Change class option to argument

[jasonmccreary]

A long standing paper-cut for me has been the --class option for the db:seed command. Most other artisan commands accept an argument for the subject.

This PR converts the class option to an argument. It has the same default (Database\Seeders\DatabaseSeeder). Just saves on typing to improve the developer experience.

Before

php artisan db:seed --class=UsersTableSeeder

After

php artisan db:seed UsersTableSeeder

[GrahamCampbell]

I don't think this break is worth it? At the least, we should support both the old and new syntax for a few years.

[jasonmccreary]

@GrahamCampbell I wouldn't think carrying both options for years is worth it. 😉 However, if it means the argument could be merged into 8.x, then I'm all for it. 😂

[Davidnadejdin]

@GrahamCampbell I wouldn't think carrying both options for years is worth it. 😉 However, if it means the argument could be merged into 8.x, then I'm all for it. 😂

your option forces you to preserve a certain order of arguments, which can interfere with optional arguments. Therefore, the old syntax is still valid

[driesvints]

@jasonmccreary can you rebase with master? After that feel free to markt his PR as ready for review. Taylor doesn't sees draft PRs.

[jasonmccreary]

@driesvints, no problem. Didn't realized I marked it as draft. 😅

[jasonmccreary]

@Davidnadejdin not sure who your comment was intended for, however, neither the before nor after versions require ordering the parameters as far as I'm aware.

[Davidnadejdin]

@Davidnadejdin not sure who your comment was intended for, however, neither the before nor after versions require ordering the parameters as far as I'm aware.

I thought that you are proposing to globally change the way of passing arguments to commands, sorry

[taylorotwell]

Hmm, I'm also not sure I'm willing to take on the breaking change unless it has more clear user benefit.

[jasonmccreary]

@taylorotwell would you be open to supporting both syntaxes as suggested by Graham.

I feel this has user benefit in the obvious less keystrokes, but more importantly the symmetry with other artisan commands. I can't be the only Laravel developer to mistakenly type artisan db:seed UserTableSeeder over the years. 😅