Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
first of all I would like to say this is my first PR targeting large application(framework) like Laravel.
I recently switched to Laravel 8.0 and found that, when generating factory, first argument (factory name) is ignored (only used to generate file name). This PR fixes this behavior so, class name is same as file name. I am not sure if current behavior is intentional, but I found that factory class name does not necessary match model name in my case. Did not find any tests for factory generation. Please, feel free to leave any feedback!
Current behavior
My models
$ php artisan make:factory ParameterLayoutFactory
Creates (Model
ParameterLayout
not found)class ModelFactory extends Factory
Expected behavior
$ php artisan make:factory ParameterLayoutFactory
Creates (class name inherited from name argument)
class ParameterLayoutFactory extends Factory
Thanks.