New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback to fallback_locale translation when empty string #34128

Closed

ahmedsayedabdelsalam wants to merge 1 commit into laravel:7.x from ahmedsayedabdelsalam:7.x

Contributor

ahmedsayedabdelsalam commented Sep 4, 2020

// ar
'foo' => ''
// en
'foo', => 'bar'

before
trans('file.foo',[],'ar') // ''

after
trans('file.foo',[],'ar') // 'bar'


          fallback to fallback_locale translation when requested translation li…

c3e6735

…ne is empty

Member

GrahamCampbell commented Sep 4, 2020

Please send this to 6.x, since this is a bug fix. :)

GrahamCampbell closed this

ahmedsayedabdelsalam mentioned this pull request

[6.x] Fix for empty fallback_locale #34136

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet