[6.0] Moved Response code from the Pipeline to the Routing Pipeline

[DarkGhostHunter]

Responsable check is now done on the Route Pipeline. This cleans the Base Pipeline class, avoiding unwanted behaviour when using it with Responsable objects in other parts of the developer application.

Also added a test to check if a Middleware that returns a Responsable (instead of keep going with the pipeline) transforms it to a Response.

[DarkGhostHunter]

Fuck yeah all green. Hitting the bed til tomorrow.

[taylorotwell]

Please describe any breaking changes users would need to account for.

[DarkGhostHunter]

For developers using the Pipeline class, if a pipe returns a value it will be returned next as-is. The Pipeline won't check if the value returned by a pipe is a Responsable instance and transform it to a Response instance.

The Pipeline is used on the Middleware processing, which will keep that behaviour. That means, if one the middlewares returns a Responsable class, it will be automatically transformed to a Response.

[florentpoujol]

Hey

Note that this would negate the effect of #29251.
Also the original PR (#24201) is more than 1 year old already.

But if the Laravel team is OK to move this special handling of Responsable objects exclusively for the middleware and in the Routing Pipeline, could we consider adding a hook method instead of overriding the whole carry() method and nest the closure (the point of #29251) .

The end of the try block in the carry method would then be:

                    $response = method_exists($pipe, $this->method)
                                    ? $pipe->{$this->method}(...$parameters)
                                    : $pipe(...$parameters);

                    return $this->handleResponse($response);

In the base class the method would just return the response, but in the Routing Pipeline it would be:

protected function handleResponse($response)
{
     return $response instanceof Responsable
                    ? $response->toResponse($this->getContainer()->make(Request::class))
                    : $response;
}

[DarkGhostHunter]

Hey

Note that this would negate the effect of #29251.
Also the original PR (#24201) is more than 1 year old already.

But if the Laravel team is OK to move this special handling of Responsable objects exclusively for the middleware and in the Routing Pipeline, could we consider adding a hook method instead of overriding the whole carry() method and nest the closure (the point of #29251) .

The end of the try block in the carry method would then be:

                    $response = method_exists($pipe, $this->method)
                                    ? $pipe->{$this->method}(...$parameters)
                                    : $pipe(...$parameters);

                    return $this->handleResponse($response);

In the base class the method would just return the response, but in the Routing Pipeline it would be:

protected function handleResponse($response)
{
     return $response instanceof Responsable
                    ? $response->toResponse($this->getContainer()->make(Request::class))
                    : $response;
}

Welp, that seems better. Does the code looks more understandable now?

[DarkGhostHunter]

I think this should be more important now that the Pipeline class is being used for Job Middlewares