[5.8] Refactoring the unless method with when in BuildsQueries class
#28965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests for "unless" are now failing. |
**WARNING :** Don't merge this PR because of the inconsistency of the correct behavior This is a breaking change because the `value` from the condition is altered by `$this->when(! $value, ...)`. I think this is inconsistent with [Illuminate\Support\Collection::unless](https://github.com/laravel/framework/blob/5.8/src/Illuminate/Support/Collection.php#L606) So, what is the correct behavior ?
|
WARNING : Don't merge this PR because of behavioral Inconsistencies. This is a breaking change because the I think this is inconsistent with Illuminate\Support\Collection::unless So, what is the correct behavior ? |
|
If this is a breaking change then please send it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.