[5.5] fixed invalid range due to - literal

[funtimeerror]

validateUrl() function fails when using php 7.3.1 with pcre 10.32 2018-09-10 due to un-escaped literals

• line 1361 has two un-escaped - literals causing the newer pcre versions to bomb out thinking its an invalid character class range
• line 1363 also has one un-escaped - literal causing the newer pcre versions to bomb out thinking its an invalid character class range

Repro:

env:

• php 7.3.1 (pcre 10.32 bundled version)
  http://www.google.com/maps fails validation

[funtimeerror]

side note: your travis-ci jobs are not targeting anything php >= 7.3 :) you may want to add travis-ci job for 7.3.3 at least

[X-Coder264]

Actually there is a Travis CI job for PHP 7.3 -> https://github.com/laravel/framework/blob/5.8/.travis.yml#L17

There was a fix for the pattern via this PR for Laravel 5.6 -> #25194 which was also backported into 5.5. What is the exact Laravel version that you are using?

[funtimeerror]

Actually there is a Travis CI job for PHP 7.3 -> https://github.com/laravel/framework/blob/5.8/.travis.yml#L17

ah, it just doesnt exist for the 5.5 branch then, since 5.5 is the LTSB should the CI job for 5.5 be updated to include php 7.3?

There was a fix for the pattern via this PR for Laravel 5.6 -> #25194 which was also backported into 5.5. What is the exact Laravel version that you are using?

and it appears that I derp'd and was still running 5.4 on this project (of which is in the process of migrating to 5.5) which is why I ran into this and re-invented the wheel.

I'm good with this PR being closed 👍

[taylorotwell]

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!