[5.4] Fix URL validation pattern #27594
Conversation
Backport of laravel#25194.
|
5.4 is no longer supported. |
|
@ahinkle Yes I know, but I'm stuck with it for a project. Can you at least merge? You don't need to make a new release or anything. |
|
Heya, unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? If so feel free to reply and we'll try to have a look. |
|
@driesvints Of course the problem has been fixed in the latest version since this is a backport of said fix... If we could upgrade we would, but at this point we're stuck with 5.4, and it's not working on PHP 7.3 because of this bug (that is literally one character). There was another PHP 7.3 compatibility fix merged with 5.4 in December, so I'm a bit confused as to why this one is rejected. |
|
@rlanvin - @devcircus Provided you a couple of resolutions. The Laravel core contributors can't track every single branch for potential breaking changes. The support for 5.4 has been dropped for well over a year now. There are significant security fixes along with bug fixes (like the one you had listed) with recent Laravel releases. If you are "stuck" take a look at Laravel Shift. It's painless and very affordable. |
Backport of #25194.