Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Add missing type to param in docblock #27395

Merged
merged 2 commits into from
Feb 3, 2019
Merged

[5.7] Add missing type to param in docblock #27395

merged 2 commits into from
Feb 3, 2019

Conversation

rodrigopedra
Copy link
Contributor

Adds JsonSerializable to the $data param docblock at Illuminate\Http\Resources\MergeValue constructor.

While working on PR's #27384 and #27394 I noticed that it as missing.

@staudenmeir @rodrigopedra
Add leading slash to JsonSerializable on docblock
70931c0 
Co-Authored-By: rodrigopedra <rodrigo.pedra@gmail.com>
@taylorotwell taylorotwell merged commit 1c2a9f6 into laravel:5.7 Feb 3, 2019
@rodrigopedra rodrigopedra deleted the docblock branch February 3, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudenmeir staudenmeir staudenmeir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigopedra @staudenmeir @taylorotwell