[5.7] Add ability to use the dollar sign for resolve with params. (Option #2) #27079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelElrafa
changed the title
|
I've updated #27078 with what I believe to be the best and cleanest approach to doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #27078 but it just does it differently in the code. Here I'm not looking over the param keys to strip out the
$, I'm just adding the$to the dependency name if the non$version wasn't found. That way everyone who's currently doing it without the$won't add any more work when resolving out.I'm aware that this will create a merge conflict with #27077 which I will fix when/if that gets merged.