Fix uniqueness of macroable objects on grammars #26461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this a breaking change for people who are using |
|
Yes, that is correct. |
|
But i'm not sure how would you deal with class identities in enheritance? |
|
For breaking changes, you should target the |
|
See above. |
|
@morloderex This seems to be a reasonable feature, is there any interest to pick this up again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my pr #24513 i added the macroable trait to the grammars outermost parent class.
But what i didn't realize is that if one where to try to register the same macro name into two different grammars only the last call to the macro method will be used sense the macro property is static and lives in the outmost parent.
So every call to macro would override another one.