[5.8] hyphen-case the Syslog program name #25784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow existing program name conventions to have more readable logs.
|
👍 but rather in the next major release, could be too surprising for users of the current release. |
lucasmichot
reviewed
Sep 26, 2018
barryvdh
changed the title
barryvdh
changed the title
|
Could do that, if Taylor let's me know I'll change it (can't properly change the base withou adding more commits for some reason) |
|
Thanks! |
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow existing program name conventions to have more readable logs. When using spaces, it looks kinda weird in Papertrail. Not sure about other services.
Eg. 'My Cool App' would be: my-cool-app, similar to other services (systemd-logind etc)
Papertrail also uses some logic to filter or group by name, which fails when using spaces..