Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix the replace placeholder methods for the the comparison rules (gt/lt/gte/lte). #25507

Closed
wants to merge 1 commit into from

Conversation

Alymosul
Copy link
Contributor

@Alymosul Alymosul commented Sep 7, 2018

This PR fixes #25481, basically the replaceMethod will check for the attribute if not present it will replace the placeholder with the passed value.

@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@martinbean
Copy link
Contributor

I am closing this pull request because it lacks sufficient explanation, tests, or both.

I opened the original Issue (#25481), which provides an explanation of the problem.

@Alymosul
Copy link
Contributor Author

Alymosul commented Sep 7, 2018

@martinbean I agree with tailor, it lacks tests. I'll submit the tests to make sure that i've come up with the proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants