[5.6] Throw exception for has() with MorphTo relationship #25337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a long-known issue that
has()
andwhereHas()
don't supportMorphTo
relationships (#5429, #18523). There are workarounds, but the fundamental problem is basically unfixable.Depending on the actual code, the user gets an exception (e.g. "unknown column") or the query "successfully" executes pointless SQL:
With this PR, the user at least receives a proper exception.
Should we include a link to one of the GitHub issues (for the workarounds)?