[5.6] Fix MorphTo eager loading and withoutGlobalScopes() #25331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withoutGlobalScopes()
doesn't work when eager loadingMorphTo
relationships:MorphTo
uses a temporary query (based onComment
) to build the relationship. At this point,withoutGlobalScopes()
can only remove scopes that were registered onComment
. WhengetResultsByType()
finally executes individual queries for the different related models, the global scopes get re-applied.We can fix it by catching the
withoutGlobalScopes()
calls and using the$macroBuffer
to apply them later to the individual queries.Fixes #18052 and #21856.