Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fixes for job queuing errors #25271

Closed
wants to merge 1 commit into from
Closed

Conversation

erupakov
Copy link

Platform: Lumen 5.6
When using scheduled jobs with queuing there is an error appear in log files:
Running scheduled command: App\Jobs\CheckIncomeJob

In Schedule.php line 99:

Call to a member function onQueue() on string
This patch fixes this error

Platform: Lumen 5.6
When using scheduled jobs with queuing there is an error appear in log files:
Running scheduled command: App\Jobs\CheckIncomeJob

In Schedule.php line 99:

  Call to a member function onQueue() on string
This patch fixes this error
@erupakov erupakov changed the title Fixes for job queuing errors [5.6] Fixes for job queuing errors Aug 20, 2018
@deleugpn
Copy link
Contributor

deleugpn commented Aug 20, 2018

I think there has been a back-and-forth about this change.

Edit: My bad. I've look at the history of this file and perhaps my memory is about somewhere else in the code.

Would be nice to have some tests about this, though. Few commits around this area without any tests already. #21820 and #21473.

@X-Coder264
Copy link
Contributor

We also got #25216 on the 5.7 branch which includes tests 😄

@taylorotwell
Copy link
Member

Need some example of how to recreate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants