New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Wrap columns in whereRowValues() #25179

Merged

taylorotwell merged 1 commit into laravel:5.6 from staudenmeir:where-row-values

Aug 11, 2018

Contributor

staudenmeir commented Aug 10, 2018 •

edited

Loading

whereRowValues() doesn't wrap the columns:

$builder = DB::table('table')->whereRowValues(['column1', 'column2'], '=', ['foo', 'bar']);
dd($builder->toSql());

// expected: select * from "table" where ("column1", "column2") = (?, ?)
// actual:   select * from "table" where (column1, column2) = (?, ?)


          Wrap columns in whereRowValues()

adfc379

Contributor

mfn commented Aug 11, 2018

You mean it's missing proper quotes when using e.g. upper case columns in Postgres.

taylorotwell merged commit 4643442 into laravel:5.6

staudenmeir deleted the where-row-values branch

August 13, 2018 21:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet