-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.6] Dont serialize csrf cookie / header #25121
Conversation
Is this the reason for the security update? Was a remote code execution possible when you know the app key and can generate encrypted cookies with manipulated serialized objects? |
@ottowayne Definitely seems so: https://www.owasp.org/index.php/PHP_Object_Injection |
Yeah, looks like you can do some nasty stuff with this. Like running "migrate:fresh --force" using a PendingDispatch which runs Artisan commands on __destruct():
But then again your application is probably already compromised if the attacker has the app key. Also the serialization is disabled for all cookies as of commits |
For reference, this issue is CVE-2018-15133. |
@kozmic It doesn't mention the not yet fixed vulnerability of Laravel 4.x though. |
@ottowayne Yes it does.
That means all versions up to 5.5.40, and all versions from 5.6.0 to 5.6.29. |
Ok, than it was just a translation issue on my side. Thanks for clearing it up 👍 |
Reference: laravel#25121 laravel@9725a8e 由於 Laravel 5.1 上游已經沒有再 maintain 了,短時間要升級上去有點困難 故自己將這個 patch 上去,自己來 maintain 這個 5.1 的 security issue hard code `XSRF-TOKEN` 不進行 serialize or unserialize 動作
No description provided.