New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Revert "Fix ConnectionInterface methods" #25094

Merged

GrahamCampbell merged 1 commit into laravel:5.6 from ntzm:revert-25092-patch-7

Aug 5, 2018

Contributor

ntzm commented Aug 5, 2018

Reverts #25092; changing the signature of an interface is a breaking change that should be done on 5.7


          Revert "Fix ConnectionInterface methods (laravel#25092)"

b86f761

This reverts commit 7a5b58b.

GrahamCampbell changed the title ~~Revert "Fix ConnectionInterface methods"~~ [5.6] Revert "Fix ConnectionInterface methods"

GrahamCampbell merged commit ddf138a into laravel:5.6

Member

GrahamCampbell commented Aug 5, 2018

Thanks. NB This change is already done on 5.7. Not sure why it was PRed again to 5.6.

ntzm deleted the revert-25092-patch-7 branch

August 5, 2018 12:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet