[5.6] Fix multiple notification recipients #24957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR laravel#24606 unfortunately broke on-demand notifications addressed to multiple recipients. This fixes Issue laravel#24729 and laravel#24956
|
Please do not modify existing tests, just add new ones. |
jmarcher
reviewed
Jul 26, 2018
| @@ -143,7 +143,7 @@ public function test_mail_is_sent_to_named_address() | |||
|
|
|||
| $user->notify($notification); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Just nitpicking but this 4 spaces should not be here.
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #24606 unfortunately broke on-demand notifications addressed to multiple recipients.
This fixes Issue #24729 and #24956