[5.6] Return instance of spy when swapping facade for a Mockery spy #24918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the main benefits of spies is that you can move the assertion to the end of the test method. For example, instead of
after the 'act' step in your test, you can do
Right now, if I want to get an instance of the spy I have to do
$spy = Facade::getFacadeRoot()
so that I can use the spy in my assertions at the end of the test, which isn't as nice as it could be. This PR simply returns the spy after creating it.