[5.6] Refactor PhpRedis connector #24824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
force-pushed
the
fix-phpredis-connector
branch
from
c8fc4fe to
8e24284
Compare
connect() and pconnect() just pass through their arguments to redis_connect()
tillkruss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an addition to #24678 thanks to @dzuelke's suggestions in #24678 (comment) and #24748.
reservedoption. It's just a reference in the docs.retry_intervaloption to persistent connections.>=3.1.3add theread_timeoutoption to connections so the authentication and database selection steps are also subject to the read timeout.connect()andpconnect()calls, since both just pass through their arguments toredis_connect().Fixes #24748.