Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] [fix] support tags as variadic params in Repository::tags #24810

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

jarektkaczyk
Copy link
Contributor

TaggableStore::tags accepts tags as array or variadic params, but the Repository::tags does not, which makes this happen:

Cache::tags(['foo', 'bar', 'baz']) // works fine:
$this->store->tags(['foo', 'bar', 'baz'])

// but

Cache::tags('foo', 'bar', 'baz') // will pass only first param to the TaggableStore:
$this->store->tags('foo') // wrong!

This PR fixes the bug.

@jarektkaczyk jarektkaczyk changed the title support tags as variadic params in Repository::tags [5.6] [fix] support tags as variadic params in Repository::tags Jul 11, 2018
@taylorotwell taylorotwell merged commit 6f7116e into laravel:5.6 Jul 11, 2018
@jarektkaczyk jarektkaczyk deleted the fix/variadic-params-for-tags branch July 12, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants