[5.7] fix #23804: attachFromStorageDisk not compatible with the queue #24809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grummfy
changed the title
Grummfy
force-pushed
the
fix/23804_mailable-attachment
branch
from
d12a963 to
c244abe
Compare
GrahamCampbell
changed the title
|
NB You actually submitted this to 5.7, not 5.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
fix the issue #23804 that create error when mail are queued with attachFromStorageDisk.
So now it will add the information in an array of data, then loop on it when we really send the message.
I add some unit test, hoping to get the error in my unit test, but failed to success in it (I didn't succeed to create the error in the unit test). But the unit test are there so let's keep them ;).