[5.6] Prevent calling the bootable trait boot method twice #24556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The User model in Spark for example uses the
Spark\Billable
trait which uses theCashier\Billable
trait, inModel::bootTraits
methodclass_uses_recursive
will return the two different Billable traits in the results, so if the Billable trait has abootBillable
method it'll be called twice:One when
model::bootTrairs
foundSpark\Billable
and one when it foundCashier\Billable
.This PR prevents calling the trait boot method multiple times by keeping track of what methods were called and prevent calling them again.