[5.6] Extract setting mutated attribute into method #24307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with accessors, code looks like now like this:
so in case of custom method functionality, it's possible to override both hasGetMutator and mutateAttribute for custom code.
But for mutator code looked so far like this:
so it's impossible to do similar change for mutator. In fact you need to override the whole setAttribute method just to make similar change because setting mutated attribute is not extracted to external method.
After this PR code for mutator condition would look like this:
so now it would be enough just to override those 2 methods instead of touching setAttribute code. Also code is more consistent now I believe.