Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Added assertLocation to TestResponse #24268

Closed
wants to merge 3 commits into from
Closed

[5.5] Added assertLocation to TestResponse #24268

wants to merge 3 commits into from

Conversation

gsingh1
Copy link
Contributor

@gsingh1 gsingh1 commented May 21, 2018

Adding an accepted PR from 5.6 #24267 to 5.5 also. Not sure if this is the correct way to do this. If not, please let me know how I can request this change.

Thanks.

@gsingh1 gsingh1 changed the title [5.5] Added assetUri to TestResponse [5.5] Added assetLocation to TestResponse May 21, 2018
@gsingh1 gsingh1 changed the title [5.5] Added assetLocation to TestResponse [5.5] Added assertLocation to TestResponse May 21, 2018
@afraca
Copy link
Contributor

afraca commented May 21, 2018

What's the reason it's not assertUri here, but assertLocation?
Also, I think 5.5 is bugfix only now, so don't get your hopes up, though Taylor can be surprising sometimes (see the changelog of 5.5)

@gsingh1
Copy link
Contributor Author

gsingh1 commented May 21, 2018

Taylor made adjustments and changed assertUri to assertLocation which I guess makes more sense - see the followed up commit here

Thanks.

@GrahamCampbell
Copy link
Member

Thanks, but 5.5 LTS is only accepting bug fixes. Please send new features to 5.6, and breaking changes to 5.7.

@gsingh1 gsingh1 deleted the 5.5 branch May 22, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants