[5.6] RenameIndex support for migrations #24147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here: laravel/ideas#443 and as suggested by @tomschlick here, opening a PR for migration call to rename index (
->renameIndex('from', 'to')
).Additionally tested on local installations of MySQL, Postgres, MS SQL - those support renaming indexes.
SQLite doesn't support renaming indexes (as is correctly pointed in laravel/ideas#443), so I'm using Doctrine and its
getRenameIndexSQL
, unfortunately it'sprotected
, so basically, I've copied the implementation (this is from Doctrine's source):So, for SQLite it's drop and re-create (and requires Doctrine), for others - it's native calls.
(Edit: wrong code snippet)