New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Allow concatenation & file for IP whitelisting when using artisan:down #24116

Closed

srmklive wants to merge 1 commit into laravel:5.6 from srmkliveforks:5.6

Contributor

srmklive commented May 5, 2018

In #24003, we can add IP addresses to access the site, when using php artisan down. One example is:

php artisan down --allow=127.0.0.1 --allow=192.168.0.0/16

The issue with this is that in order to white list multiple IP addresses we have to add the allow option multiple times.

This PR further modifies the behavior to allow a user to do the following:

Allow multiple IP addresses through a single allow option by using a , or | symbol:

php artisan down --allow=127.0.0.1,192.168.0.0/16

Add a file path to allow option. The file will contain IP addresses in the following format:

127.0.0.1
192.168.0.0/16


          Allow concatenation & file for IP whitelisting when using artisan:down

889b645

Member

taylorotwell commented May 5, 2018

I would just make a composer script in your composer.json that does the long command you want.

taylorotwell closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet