[5.6] Allow integer values for whereYear() in SQLite #24115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whereYear()
doesn't work with integer values in SQLite:This is caused by the strict comparison between the string result of
strftime()
and the integer value. We can solve it by casting the value to a string.Although the documentation example uses a string, IMHO integers should also work (as they do in MySQL).
Adds SQLite integration tests for date queries.
Fixes #24058.