[5.7] Pass route to custom URL formatters #24049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add another test case for this functionality instead of modifying the existing one? |
|
I'm not sure what you're asking. Are you saying that you cannot write tests until another 5.6 PR is ported to 5.7? If so, why not? |
|
Tests will fail if added before linked PR get's merged. |
imbrish
force-pushed
the
route-for-formatter
branch
from
3de9910 to
a453b7f
Compare
|
Somehow I overlooked the fact, that I don't need to test for the relative route after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass route for which URL is currently generated to the custom host and path formatters.
This is a part of a series of pull requests simplifying localization of URLs, more details here #24048.