[5.6] Use offset only when limit is available #23998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revamp Software, Inc. <softwarevamp@gmail.com>
Signed-off-by: Revamp Software, Inc. <softwarevamp@gmail.com>
afraca
reviewed
Apr 25, 2018
| @@ -175,6 +175,6 @@ protected function setCustomModes(PDO $connection, array $config) | |||
| */ | |||
| protected function strictMode() | |||
| { | |||
| return "set session sql_mode='ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'"; | |||
| return "set session sql_mode='ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'"; | |||
There was a problem hiding this comment.
These are 2 changes in 1 commit (& PR), split it up for discussion
There was a problem hiding this comment.
This PR:
#23948
also is about changing strict mode
GrahamCampbell
changed the title
|
Please send a PR with only one change in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Revamp Software, Inc. softwarevamp@gmail.com