Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] fix for HasManyThrough returning incorrect results with chunk() (#21774) #23923

Closed
wants to merge 1 commit into from

Conversation

AmmarRahman
Copy link

fixes issues with chunk() and each() behaviour on HasManyThrough. Root cause of the issue is, unlike the get() method that is handled on the relationship, these methods are handled through Eloquent Query Builder without updating of the columns that should be selected.

@GrahamCampbell GrahamCampbell changed the title fix for HasManyThrough returning incorrect results with chunk() (#21774) [5.5] fix for HasManyThrough returning incorrect results with chunk() (#21774) Apr 18, 2018
@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@AmmarRahman
Copy link
Author

Hi Tailor,
The issue is thoroughly explained in #21774. HasManyThrough chunk() method does not produce the expected results. I will try to expand on the seeder and write tests for chunk on HasManyThrough next week.

Thanks for the amazing framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants