Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Pending Dispatch early dispatch #23904

Closed
wants to merge 2 commits into from

Conversation

dbpolito
Copy link
Contributor

@dbpolito dbpolito commented Apr 16, 2018

This is related to #23866 , which i didn't get much feedback unfortunately.

But looking at this PR that got merged today: #23890 , which is a pretty similar solution, i basically decided to give it a shot.

In summary, this is for when you call dispatch(), you can dispatch it when you want, without having to unset the variable for example.

Useful for when you are at php artisan tinker or when you want to fetch the return of the job handle or job id

@GrahamCampbell
Copy link
Member

Hmm, this is missing protection against editing a job that's already been dispatched.

@tillkruss
Copy link
Contributor

It's also missing tests.

@tillkruss tillkruss closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants