[5.5] FileSystem returns files and directories sorted by name #23884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but I don't think this qualifies as a fix for an LTS release. This is more of a feature. The method description doesn't claim it sorts the values. |
|
You're right, Laravel doesn't promise a sorted result. But since it was "working" in 5.4, I thought it would be good to have for people who are (unknowingly) relying on it. |
|
Technically, Laravel doesn't promise any ordered results in 5.6 either. There were no tests added to #23387 to verify the order of the result, neither where there any documentation changes that backs it up. It can be removed in the future, just like it was in 5.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23387.
Fixes #23883.