[5.7] Add PR template #23846
Merged
[5.7] Add PR template #23846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no oxford comma? 😄 |
|
@browner12: I'm ESL all the way. Feel free correct or extend it 🙂 |
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
May 6, 2018
- this pr is cherry-picked from the laravel#23846 since the default branch is 5.6 * add simple PR template * update copy (cherry picked from commit 8124f9b)
Merged
taylorotwell
pushed a commit
that referenced
this pull request
May 7, 2018
TBlindaruk
added a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
May 13, 2018
- this pr is cherry-picked from the laravel#23846 since the default branch is 5.6 * add simple PR template * update copy (cherry picked from commit 8124f9b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still see PRs with in-descriptive titles, missing descriptions and no tests.
It's sometimes quite hard to figure out what the PR actually does for the changelog with a proper title/description.
Regular contributors know our guidelines, but new users might not.