Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Schedule - Use is_subclass_of() #23774

Closed
wants to merge 1 commit into from
Closed

[5.6] Schedule - Use is_subclass_of() #23774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Illuminate/Console/Scheduling/Schedule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Illuminate\Container\Container;
use Illuminate\Support\ProcessUtils;
use Illuminate\Contracts\Queue\ShouldQueue;
use Symfony\Component\Console\Command\Command as SymfonyCommand;

class Schedule
{
Expand Down Expand Up @@ -74,7 +75,7 @@ public function call($callback, array $parameters = [])
*/
public function command($command, array $parameters = [])
{
if (class_exists($command)) {
if (is_subclass_of($command, SymfonyCommand::class)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the linked PR

$command = Container::getInstance()->make($command)->getName();
}

Expand Down