[5.7] Improve nested rules in validated data #23708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(re-submit of #23703 for 5.7)
#20974 fixed an issue with array rules (
users.*.name
) when returning the validated data.Nested rules now get reduced to the first key.
However, this wouldn't be necessary for rules without an asterisk:
This PR differentiates between rules having and not having an asterisk. Only the former get reduced.
For the request validation this is easy to achieve because
Request::only()
already supports nested keys.Validator::validate()
however usesCollection::only()
which doesn't support nested keys:So we have to use
data_get()
andArr::set()
(as used inRequest::only()
) to bring support for nested keys toValidator
.Fixes #23612.