[5.6] Fix #23592 (SeeInOrder) #23594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertSeeTextInOrder to actually assert something
Jantho1990
force-pushed
the
bugfix/see-in-order
branch
from
723cf73 to
f62cc01
Compare
Jantho1990
force-pushed
the
bugfix/see-in-order
branch
from
f62cc01 to
99cb7af
Compare
carusogabriel
suggested changes
Mar 18, 2018
| /** | ||
| * The string we want to check the content of. | ||
| * | ||
| * @var |
There was a problem hiding this comment.
Missing var type.
Strange that Style CI didn't cached it 🤔
There was a problem hiding this comment.
It's not a code style bug, that's why. It's just a syntax error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a SeeInOrder PHPUnit Constraint to address Issue #23592. Calling
assertSeeInOrder()orassertSeeTextInOrder()should now result in PHPUnit registering that assertions were made (and thus not marking tests with only those assertions as risky). Also added a test file to make sure PHPUnit is calling the assertions.