[5.5] Set up loop variable correctly on all Traversable objects #23388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarpio89
reviewed
Mar 20, 2018
| if (is_array($data) || $data instanceof Countable) { | ||
| $length = count($data); | ||
| } elseif ($data instanceof Traversable) { | ||
| $length = iterator_count($data); |
There was a problem hiding this comment.
This breaks when the data used in the view comes from a generator (using yield)...
Exception(code: 0): Cannot traverse an already closed generator
taylorotwell
pushed a commit
that referenced
this pull request
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$loopvariable within Blade's@foreachis not filled correctly if the object given implements\Traversablebut not\Countable. The reason is that the stack size is not determined properly. This leads to unexpected behaviour using i.e.$loop->last.This commit fixes the
$loopvariable so it works correctly with all\Traversablestacks (like\DatePeriod). It won't break any existing features as it just extends the functionality.