[5.6] Provide access to validated dataset

[adam1010]

Currently in your controller if you're using:
$data = $request->validate([...]);

If you need to switch to using advanced rules, there is no firect method available for accessing the validated data:

$validator = Validator::make($request->all(), [...]);
$validator->sometimes('phone', 'required', function(){ ... });
$validator->validate();
// Now how do you get your $data variable?

$data = $validator->getDataForRules(); // my new method
// OR
$data = $validator->getDataValidated(); // this takes care of calling validate()

[GrahamCampbell]

Just a small optimization, but I suspect the following is faster and does the same:

return explode('.', $rule, 2)[0];

The str_contains is not necessary, and the limit arg to explode will increase performance by early termination.

[adam1010]

Great -- I actually copied that line from Foundation/Providers/FoundationServiceProvider.php so the optimization can be made there as well.

Is there any way this can go into 5.6? I really need this in a project I'm working on.

[GrahamCampbell]

Yes, please target the 5.6 branch. I marked it as 5.7 because you targetted master. :)

[adam1010]

Got it! I've rebased off the 5.6 branch and implemented your change. Are unit tests needed or is the PR good as-is?

[GrahamCampbell]

Tests would be great please. :)

[adam1010]

I've added tests. Anything else I can do to get this merged faster?

[adam1010]

TravisCI appears to be failing due to another commit that is already on 5.6

Cannot redeclare Illuminate\Tests\Database\DatabaseQueryBuilderTest::testWhereTimePostgres

[deleugpn]

Can't the validate method itself return the data like the validate in the request?

[adam1010]

@deleugpn Currently validate() does not return anything -- are you saying we should have it return the validated data from my new function?

return $this->getDataForRules();

That would probably be preferable, but I didn't want to delay this PR if that was going to be a controversial change. If it's not controversial I can delete my getDataValidated() method and instead just have the validate() method return $this->getDataForRules();

[deleugpn]

I guess that would be a breaking change, yes. So maybe you can open a separate PR to change that tagging 5.7 while keeping this one as-is tagging 5.6

[taylorotwell]

Probably validated could return the data being validated similar to $request->validate() Feel free to open a new PR for that.

[adam1010]

@taylorotwell Thanks Taylor -- I've updated the code and created a new PR to add a return value for validate() so that it mimics $request->validate()

#23397