[5.5] Fix PostgresGrammar whereTime method with correct casting. #23318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinguinjkeke
changed the title
pinguinjkeke
changed the title
|
What is the current behavior? What does this change? How can we be sure that this wouldn't break existing Laravel installations? |
|
@sisve Hello. Currently So it cannot break something that already broken ;) |
|
Wrong branch. 5.6 is the current release. |
|
@taylorotwell It's a bugfix. Shouldn't it be merged to current LTS version? From Laravel contribution doc: |
|
Whoops. Forgot 5.5 is an LTS 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar as whereDate, whereTime should cast timestamp to time like
created_at::time.It should be merged to 5.6 and master branches too.
Link: https://www.postgresql.org/docs/9.6/static/functions-datetime.html