[5.6] Queue::bulk() fake now properly pushes expected jobs #23294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkuhl
changed the title
|
This PR also now passes |
tillkruss
changed the title
|
Can you provide some tests for this change? |
|
@jmarcher Test has been added |
|
For full transparency, this issue also exists in Laravel 5.5. |
|
Will this issue be resolved in Laravel 5.5? |
|
Feel free to PR this to 5.5. We can only automatically handle this if it went to 5.5 first, then we'd just merge upwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Laravel is unable to perform assertions on work pushed to the queue in a bulk fashion because the fake queue does not actually push the given jobs. This PR enables work (when using the Fake) to actually be pushed to the queue, allowing tests to perform assertions.