[5.6] [WIP] Add notification database channel custom types #23245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #23236
This PR introduces the same behavior to the database notification channel to keep notification channels data consistency.
Use case: I'm adding notification to database and broadcasting them to the user. But if user has missed notifications - he can call
GET /notifications
later and get the same data which was broadcasted earlier. Otherwise notification type will be mismatch and there will be issues with data merge.The only thing I don't like in this implementation is method naming. Type resolver checks if
broadcastType()
method exists inNotification
. Earlier I suggested namebroadcastAs()
inspired from Broadcasting Event. Taylor's namebroadcastType()
is way better, but still coupled with broadcasting. Maybe it's better to rename it to more genericgetType()
?