[5.5] Fix assertRedirect #23180
Closed
[5.5] Fix assertRedirect #23180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update EncryptCookies.php Just a quick cleanup, `$c` is used when `$cookie` is better, plus `$cookieName` and `$name` are used when they should really be either `$cookieName` or `$name`. * remove whitespace.
It doesn't really make sense to make the getter protected function if the setter is public.
…into tonysm-channel-classes
This is a re-write / re-work of many of @phroggyy's ideas to improve logging. Implemented: Multi-driver logging support so you can have multiple logging channels per app. "Pipes" in @phroggyy's pull request have been re-worked as "taps". Allows customization of logging channel post-creation. Continued support for functionality provided by configureMonologUsing maintained using custom driver type with factory invokable that returns any PSR3 compatible logger. This allows full customization of entire logging channel. I decided not to implement Log::event functionality from PR because I think that would be better suited for something like a ShouldLog interface on the event itself (to complement ShouldBroadcast, etc.). Primary breaking changes: New log configuration file / settings. configureMonologUsing now custom driver type. Illuminate\Contracts\Log removed. Was literal duplication of PSR3 logging interface. Illuminate\Log\Writer renamed to Illuminate\Log\Logger.
As with laravel#22484 , when inserting a pivot record via `->attach()` the `InteractsWithPivotTable.php` trait doesn't check to see if the pivot table has a model representation. It' simply finds the table name and inserts a new record. Because of this, the timestamps are passed as `Carbon` instances and then turn to strings via its `toString()` method. If the consumer is using a pivot Model, it should use that models dateFormat to format by, not the `toString()` method. This simply news-up the pivot model, fetches it's dateformat and formats the `$fresh` date against it.
* Cache loggers * Test LogManager caches Logger instances * Use assertSame
Co-authored-by: Anand Capur <git@anand.io>
* Remove card-default class * Remove card-default class * Remove card-default class * Remove card-default class * Remove card-default class
…3132) * Fixes starting of two database transactions in tests * indentation fixed
It's now under on its own namespace to co-live with Illuminate\Collection. And this is preventing us to require it.
remove leading slash
…id/framework into citricsquid-captures-bad-env-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to #23176 for 5.5