[5.6] Make sure transaction won't be started twice for RefreshDatabase #23121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... I've found that @skollro are you using Orchestra too or issue appears for Laravel built-in TestCase? |
|
Code formatting isn't quite right and we need a better explanation of the issue and fix. /cc @themsaid Thanks! |
|
Yeah, it would fix the issue I've explained in #22596 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue introduced in #22596 with starting transaction twice for RefreshDatabase class.
@skollro and @a-komarev can you confirm this will fix the issue? I really don't like code duplication but maybe it should be moved to other trait